Fix #18118.#18119
Draft
dkocher wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes #18118 by enabling WebDAV locking for Nextcloud and ownCloud sessions when OCS capabilities report locking support. Previously the profiles disabled WebDAV locking globally via the webdav.lock.enable=false property, which caused the Lock feature lookup to return null. Now the sessions explicitly return a DAVLockFeature instance when ocs.locking is true, and the profile-level override is removed.
Changes:
- Return
DAVLockFeaturefrom_getFeature(Lock.class)in bothNextcloudSessionandOwncloudSessionwhen OCS reports locking is supported. - Remove the
webdav.lock.enable=falseproperty override from the Nextcloud and ownCloud default profiles. - Clean up now-unused
DAVDirectoryFeatureandDirectoryimports inNextcloudSession.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nextcloud/src/main/java/ch/cyberduck/core/nextcloud/NextcloudSession.java | Return DAVLockFeature for Lock feature when OCS locking is enabled; remove unused imports. |
| owncloud/src/main/java/ch/cyberduck/core/owncloud/OwncloudSession.java | Add DAVLockFeature import and return it for the Lock feature when OCS locking is enabled. |
| profiles/default/Nextcloud.cyberduckprofile | Remove webdav.lock.enable=false profile override so WebDAV locking is no longer globally disabled. |
| profiles/default/ownCloud.cyberduckprofile | Remove webdav.lock.enable=false profile override so WebDAV locking is no longer globally disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.